Mueller sprayer Master switch didn't disable painting#41
Open
gunicsba wants to merge 2 commits intoAgOpenGPS-Official:developfrom
Open
Mueller sprayer Master switch didn't disable painting#41gunicsba wants to merge 2 commits intoAgOpenGPS-Official:developfrom
gunicsba wants to merge 2 commits intoAgOpenGPS-Official:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix a case where the Mueller sprayer master switch did not disable painting by adjusting how ClientState::is_element_or_parent_off() determines parent/child relationships in the uploaded DDOP, specifically when the relevant child object is a DeviceProcessData instead of a DeviceElement.
Changes:
- Extend
ClientState::is_element_or_parent_off()to also considerDeviceProcessDatachildren (via DDI→element mapping) when determining whether an element’s parent is off. - Bump project patch version from
1.3.1to1.3.2.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/task_controller.cpp |
Adds a DeviceProcessData-based path for parent detection in is_element_or_parent_off() |
CMakeLists.txt |
Increments patch version to reflect the fix release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Strengthen logic Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out Element 0 wasn't the type we expected. This commit fixes that.